loose: rename only if needed

gitpython-developers / gitdb

IO of git-style object databases

http://gitdb.readthedocs.org

Other

218 stars 65 forks source link

loose: rename only if needed #52

Closed efiop closed 5 years ago

efiop commented 5 years ago

Our user was experiencing issue [1] when using a git repository on NTFS mount running on Linux. The current check checks if we are running on Windows, but it should really check if we are on NTFS. And since checking fs type is not that trivial and not efficient, it is simpler and better to just always apply NTFS-specific logic, since it works on other filesystems as well.

[1] https://github.com/iterative/dvc/issues/1880#issuecomment-483253764

villasv commented 5 years ago

Just here to provide additional detail. This issue is very critical for WSL users interacting with NTFS through bash, and is a very common scenario.

Byron commented 5 years ago

Thanks a lot for your contribution! I will probably manage to get a new release of GitDB and GitPython out this weekend.