search

gitsh01 / libertyvillagers

Architectury Minecraft Mod for Villagers
13 stars 4 forks source link

Ver. 1.0.15 is flagged for 1.20.1 Fabric but is built against Java 21 #134

Open Hexblood opened 1 month ago

Hexblood commented 1 month ago

1.20.1 is built on Java 17. So a Java 21 build does not work. I am not certain but I think it is 1.20.4 or 1.20.5 where Minecraft makes the change to Java 21.

I am getting this listing on Modrinth if that matters for you at all.

Dekamir commented 1 month ago

Have the same issue, also on Modrinth.

Routhinator commented 1 month ago

Full error for reference:

Uncaught exception in thread "main"
java.lang.RuntimeException: Error creating Mixin config libertyvillagers.mixins.json for mod libertyvillagers
    at net.fabricmc.loader.impl.launch.FabricMixinBootstrap.init(FabricMixinBootstrap.java:96)
    at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:151)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: org.spongepowered.asm.launch.MixinInitialisationError: Error initialising mixin config libertyvillagers.mixins.json
    at org.spongepowered.asm.mixin.transformer.Config.create(Config.java:153)
    at org.spongepowered.asm.mixin.Mixins.createConfiguration(Mixins.java:100)
    at org.spongepowered.asm.mixin.Mixins.addConfiguration(Mixins.java:87)
    at net.fabricmc.loader.impl.launch.FabricMixinBootstrap.init(FabricMixinBootstrap.java:94)
    ... 3 more
Caused by: java.lang.IllegalArgumentException: The requested compatibility level JAVA_21 could not be set. Level is not supported by the active JRE or ASM version (Java 17.0, ASM 9.6 (ASM10_EXPERIMENTAL))
    at org.spongepowered.asm.mixin.MixinEnvironment.setCompatibilityLevel(MixinEnvironment.java:1627)
    at org.spongepowered.asm.mixin.transformer.MixinConfig.initCompatibilityLevel(MixinConfig.java:557)
    at org.spongepowered.asm.mixin.transformer.MixinConfig.postInit(MixinConfig.java:502)
    at org.spongepowered.asm.mixin.transformer.MixinConfig.onLoad(MixinConfig.java:430)
    at org.spongepowered.asm.mixin.transformer.MixinConfig.create(MixinConfig.java:1293)
    at org.spongepowered.asm.mixin.transformer.Config.create(Config.java:148)
    ... 6 more
Routhinator commented 1 month ago

Notable: There were 2.0.0 betas released, then this 1.0.15 release.. and it's built against Java 21. With that in mind, should folks on 1.20.1 be installing the 2.0.0 beta? Or sticking with 1.0.14 until this is fixed?

mpustovoi commented 1 month ago

Even the version name says it: image

mpustovoi commented 4 weeks ago

Come on. It can't be that hard to change one field in the project version from 1.20.1 to 1.20.6

Routhinator commented 4 weeks ago

Not sure who that was directed at, if its the mod owner.. They might be busy with end of school year or something.

If me, this version comes up with an explicit filter for 1.20.1 becausd its marked as 1.20.x compatible in the modrinth version that was created, regardless of any text in the version number.

The modrinth metadata is wrong. So while this should only come up in updates for 1.20.6 its coming up for anyone updating a modpack via a launcher consuming the modrinth API as a valid 1.20.x version.

mpustovoi commented 14 hours ago

Unfortunately, it's still a thing.