#554 - "Remove branch" button is not displayed as expected

[LetItRock]

Changed show "Delete branch" button logic:

• pull request state should be closed or merged
• user must have push permissions to head repository
• head reference should exist

I have tested this change and its working for me... but it would be better if you @alorma will do some testing also...

[alorma]

@juherr ping!

[juherr]

If you provide an apk, I will test it on my side.

[alorma]

👍

[alorma]

Great! If you could generate an APK, and send it to @juherr , he can test :P

[alorma]

Merge the latest change from develop plz

[LetItRock]

Ok. @juherr I have sent APK to you :) Please check your email box julien@herr.fr

[juherr]

:+1: As replied by email, let me few days to test it because I don't have any merged pull-request.

[LetItRock]

You can create pull request for my repo changing README.md https://github.com/LetItRock/test And I will merge it...

[juherr]

Nice try but: "Failed to delete branch" on both refused and merged branches. Any way to activate logs?

[LetItRock]

That means that we get different response from 204... https://developer.github.com/v3/git/refs/

[alorma]

If you tell me where to test, i will test it later

[LetItRock]

@juherr could you check it again with latest APK I have sent?

[juherr]

It works now ! Congratulations

[alorma]

Merged!

[LetItRock]

Great! :) Next time I should be more precise with testing...

[alorma]

Doing those PRs was awesome!