gitskarios / Gitskarios

GitHub Android application

MIT License

526 stars 73 forks source link

unable to edit after post #575

Closed GeorgeWL closed 7 years ago

GeorgeWL commented 8 years ago

https://github.com/ccrama/Slide/issues/2160

https://streamable.com/xq21

alorma commented 8 years ago

? please, explain the problem

GeorgeWL commented 8 years ago

when I attempt to edit a comment on an issue, the edit doesn't show as being made in the interface.

And it doesn't propagate to the web version either.

MelvynEzi commented 8 years ago

I can confirm. I had to use the browser on desktop version to edit the comment.

MelvynEzi commented 8 years ago

@alorma this is a functionality breaking issue. editing a freshly posted comment will not change the comment, sometimes even stating that its not ready.

alorma commented 8 years ago

Test comment

alorma commented 8 years ago

Mmm, i've updated an issue comment (comment above), and it changed on the web

MelvynEzi commented 8 years ago

Test edited 1

MelvynEzi commented 8 years ago

Test edited 2

MelvynEzi commented 8 years ago

Hmm.. seems like when having a bad connection causes the changes to be lost when attempting to edit.

MelvynEzi commented 8 years ago

Somehow, some comments (in another pull request of another repo) would only show a toast "Not ready"

GeorgeWL commented 8 years ago

Could it be something as simple as the API being slow to respond occasionally?

MelvynEzi commented 8 years ago

"Not ready" toast shows even after 1 week.

GeorgeWL commented 8 years ago

I just had a new one. edit causes app crash, I guess it's a new issue.

GeorgeWL commented 8 years ago

584

webmaster33 commented 8 years ago

I also had crash, when tapping the edit icon.

alorma commented 8 years ago

Fixed

ghost commented 8 years ago

Nope for me.

alorma commented 8 years ago

I not deployed it to production yet....

MelvynEzi commented 8 years ago

Edit: solved stacktrace

alorma commented 8 years ago

O_o, well, it's other crash

webmaster33 commented 7 years ago

Test message. Edited.

webmaster33 commented 7 years ago

Now comment editing works for me, doesn't crash. The only issue is, that issue is not refreshing automatically, after edit was submitted. Version 4.4.8. Hmmm. Now refreshed automatically after editing.

MelvynEzi commented 7 years ago

You'll have issues editing comments on PRs and issues in repos that you don't own (other than this).

webmaster33 commented 7 years ago

This is not my issue, but still does not crash, when editing. Also I don't see edit icon on other comments, just mine.

alorma commented 7 years ago

So, can i close the issue?

webmaster33 commented 7 years ago

This seems to work in last version. Edited.