gitskarios / Gitskarios

GitHub Android application
MIT License
526 stars 73 forks source link

Broken diff view and crash when viewing a file in a PR #579

Open nisavid opened 8 years ago

nisavid commented 8 years ago

When I view a PR, then navigate to its files, then tap on a file, I see two oddities:

Broken single-file diff view

Build version: 4.4.3 
Build date: 2016-09-11 20:49:48 
Current date: 2016-09-14 23:12:45 
Device: Huawei Nexus 6P 

Stack trace:  
java.lang.NullPointerException: Attempt to read from field 'java.lang.String com.alorma.github.sdk.bean.info.RepoInfo.branch' on a null object reference
    at com.alorma.github.sdk.services.content.GetFileContentClient.getApiObservable(GetFileContentClient.java:21)
    at com.alorma.gitskarios.core.client.BaseClient.observable(BaseClient.java:45)
    at com.alorma.github.ui.fragment.content.source.FileFragment.getContentObservable(FileFragment.java:22)
    at com.alorma.github.ui.fragment.content.BaseFileFragment.getContent(BaseFileFragment.java:43)
    at com.alorma.github.ui.fragment.content.BaseFileFragment.onStart(BaseFileFragment.java:38)
    at android.support.v4.app.Fragment.performStart(Fragment.java:2106)
    at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1146)
    at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1290)
    at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:801)
    at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1677)
    at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:536)
    at android.os.Handler.handleCallback(Handler.java:751)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6077)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

This is with Gitskarios 2.15.0 on a Nexus 6P running Android 7.0.

I think this worked for me recently, so I wonder if it's related to GitHub's latest changes.

MelvynEzi commented 8 years ago

Same as reported in #573

MelvynEzi commented 8 years ago

Damn this is annoying me a lot.. find myself using the mobile site more. :(

alorma commented 8 years ago

Will fix today, sorry