Feature: View and interact with PR reviews

[nisavid]

GitHub recently released some substantial enhancements for PR reviews.

New features on github.com

• PR collaborators can now have multiple conversations per line.

• A review can be created, have line comments added to it, and be submitted with an overall comment. When submitting, the reviewer can choose to just leave a comment (as before), approve the changes, or request additional changes.

• PR comments can now be shown as indicating that the comment author "commented" (as before), "reviewed", or "suggested changes".

• Protected branches can now require that at least one reviewer has approved a PR before it can be merged in.

Problems in Gitskarios 2.15.0

Gitskarios doesn't handle these changes well.

• The PR conversation view has issues with the new features.
  • There is no distinction between comment types ("commented"/"reviewed"/"suggested").
  • If a line has multiple conversations, the comments are shown interleaved, sorted by time and not grouped by thread.

• Comments that are submitted with Request changes (and possibly also with Approve—I didn't test this) do not show up at all.

• There is no indication that an unapproved PR cannot be merged into a protected branch that requires approval, nor why it cannot be merged.

• The PR file view (for a single file) is broken in a few ways.
  • Presumably, even if it was fixed to restore its previous functionality, it would still be missing the new review and comment features.

[alorma]

... github released yesterday, please hold on and let me study this new api

[alorma]

There's no API for new review flow, we should wait until GH release it

[nisavid]

GitHub recently released preview versions of APIs for Pull Request Reviews and Pull Request Review Comments. Of course, while in preview, they are subject to change without notice. Nonetheless, the current information is available if you want a sneak peek.