search

gitskarios / Gitskarios

GitHub Android application
MIT License
526 stars 73 forks source link

Notifications page, items not hiding after they was viewed #600

Closed webmaster33 closed 8 years ago

webmaster33 commented 8 years ago

On Notifications page, items not hiding after they was viewed.

I have to tap the 3 point icon, tap Make as read to hide it.

1) Could be possible to make as read after it was opened?

2) Also put a menu item on the page viewing the issue, to make as read?

Thanks!

alorma commented 8 years ago

1) You can configure it in settings

2) Not for now, i need a thread_id and api doesn't provide it

ghost commented 8 years ago

today we have found 10 bug XD

webmaster33 commented 8 years ago

1) uhm, sorry, I missed this option :-(

webmaster33 commented 8 years ago

2) not sure, if you need anything special for this. Just a timestamp, when user did open the issue. You store it locally. Then query the timestamp of the last comment. If timestamp of last comment is bigger, then this issue has new comment. Does it make sense?

alorma commented 8 years ago

To mark notification as read i need a thread_id

webmaster33 commented 8 years ago

thread_id = issue id?

alorma commented 8 years ago

no, is not the same.

https://developer.github.com/v3/activity/notifications/