gitskarios / Gitskarios

GitHub Android application
MIT License
527 stars 73 forks source link

Notification sign out bug #645

Open rancidfrog opened 7 years ago

rancidfrog commented 7 years ago

When there is a notification and you sign out, notification remains even though signed out: And, clicking notification crashes app, (since already signed out, I guess):

Build version: v.4.7.4 

Stack trace:  
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.alorma.github/com.alorma.github.ui.activity.IssueDetailActivity}: java.lang.NullPointerException: Cannot return null from a non-@Nullable @Provides method
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2646)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2707)
    at android.app.ActivityThread.-wrap12(ActivityThread.java)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1460)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6077)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)
Caused by: java.lang.NullPointerException: Cannot return null from a non-@Nullable @Provides method
    at dagger.internal.Preconditions.checkNotNull(Preconditions.java:47)
    at com.alorma.github.injector.module.ApiModule_GetTokenFactory.get(ApiModule_GetTokenFactory.java:21)
    at com.alorma.github.injector.module.ApiModule_GetTokenFactory.get(ApiModule_GetTokenFactory.java:7)
    at dagger.internal.DoubleCheck.get(DoubleCheck.java:46)
    at com.alorma.github.injector.module.issues.IssueDetailModule_ProvideRestFactory.get(IssueDetailModule_ProvideRestFactory.java:37)
    at com.alorma.github.injector.module.issues.IssueDetailModule_ProvideRestFactory.get(IssueDetailModule_ProvideRestFactory.java:10)
    at dagger.internal.DoubleCheck.get(DoubleCheck.java:46)
    at com.alorma.github.injector.module.issues.IssueDetailModule_ProvideIssueCommentBaseRxPresenterFactory.get(IssueDetailModule_ProvideIssueCommentBaseRxPresenterFactory.java:44)
    at com.alorma.github.injector.module.issues.IssueDetailModule_ProvideIssueCommentBaseRxPresenterFactory.get(IssueDetailModule_ProvideIssueCommentBaseRxPresenterFactory.java:11)
    at dagger.internal.DoubleCheck.get(DoubleCheck.java:46)
    at com.alorma.github.ui.activity.IssueDetailActivity_MembersInjector.injectMembers(IssueDetailActivity_MembersInjector.java:60)
    at com.alorma.github.ui.activity.IssueDetailActivity_MembersInjector.injectMembers(IssueDetailActivity_MembersInjector.java:11)
    at com.alorma.github.injector.component.DaggerApiComponent$IssueDetailComponentImpl.inject(DaggerApiComponent.java:1181)
    at com.alorma.github.ui.activity.IssueDetailActivity.injectComponents(IssueDetailActivity.java:177)
    at com.alorma.github.ui.activity.base.BaseActivity.injectComponents(BaseActivity.java:56)
    at com.alorma.github.ui.activity.base.BaseActivity.onCreate(BaseActivity.java:43)
    at com.alorma.github.ui.activity.IssueDetailActivity.onCreate(IssueDetailActivity.java:138)
    at android.app.Activity.performCreate(Activity.java:6664)
    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1118)
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2599)
    ... 9 more