gittuf / gittuf

A security layer for Git repositories
https://gittuf.dev
Apache License 2.0
439 stars 28 forks source link

Add new ssh package based on `ssh-keygen` #414

Closed lukpueh closed 3 weeks ago

lukpueh commented 1 month ago

For signing and Key import paths to either public or private, plaintext or encrypted, rsa, ecdsa or ed25519 keys are supported (akin to git's user.signingKey configuration).

Also adds basic smoke tests for the ssh package, and replaces updates dsse tests to use this module.

lukpueh commented 1 month ago

Note: Tests fail because ssh-keygen refuses to consider world-readable signing keys. Since read permissions can't be checked into git, we'll need to fix this in test setup.

adityasaky commented 1 month ago

This looks great! Left some comments from a first look.

lukpueh commented 1 month ago

Just pushed a bunch of code comments and renames (sorry for the force push). Let me fix lint and tests and mark it as ready for review.

I think we can work on integration with TUF metadata in a follow-up PR.

lukpueh commented 3 weeks ago

@adityasaky: IMO this is ready to be merged. I can create a ticket for testing encrypted ssh keys on windows.

lukpueh commented 3 weeks ago

I can create a ticket for testing encrypted ssh keys on windows.

--> https://github.com/gittuf/gittuf/issues/422