Closed Phoscur closed 2 years ago
@phoscur yeah that works. The only value in the hardcoded macros is to serve as a quickstart example to people, so other than having some breadth it doesn't matter much.
Super slick you were able to reverse engineer their Onyx interface!
Yeah, first I wanted to use cheerio to parse the HTML, but as that is not actually delivered prerendered by ORYX, I took a look at the other requests and found an extensive GraphQL API, which is easy to use.
@eric-fulfil plans on merging this? the other PR (#6) includes it aswell.
Nope, wrong account on my part!
Not fixing conflicts, since these changes are included in the other PR aswell
This is a first step towards #1 proposing a few new conventions concerning folder structure.
Will be followed up by adding more configurability (through env).
@gittyeric I don't think it's worth cleaning up the git history and moving my own macros out, are you okay with having my-macros.ts in there redundantly for now?