search

giuinktse7 / LapisItemEditor

An item editor for the OTB format
MIT License
14 stars 10 forks source link

'Market' values are not being read / saved / changed within the app. #4

Closed Kopiernik closed 7 months ago

Kopiernik commented 9 months ago

It is impossible to read / save / change anything in 'market' section for any item. 'Trade as' and 'Show as' seems to be not working at all, whenever I fill it with any id, its not saving it and showing the same id from my input on every item with 'market' option checked, but its never saving it to items.otb, if I dont edit anything it always shows unchecked 'Trade and Show as' with id 100, even for already existing items on the server.

Kopiernik commented 9 months ago

image

giuinktse7 commented 8 months ago

Correct, that is unfortunately not implemented yet. I made this tool with the main goal of generating OTBs for new clients and never got around to finishing the editing functionality.

I'll see if I can find the time to add it sometime soon, but if not I will happily accept a PR for it.

giuinktse7 commented 7 months ago

This should be fixed in the latest release. Note however that the items.otb file does not contain market information. This information is stored in the appearances.dat file. You can save the modified appearances.dat by using the new button Save client data:

image

Depending on your server you might need to update the appearances.dat for both the client and the server. I think TFS still uses items.otb, but e.g. canary uses appearances.dat instead (in data/items).