search

giulionf / realtweetornotbot

Scans screenshots of tweets on reddit and links the corresponding tweet
https://www.reddit.com/u/realtweetornotbot
MIT License
76 stars 5 forks source link

use rapidfuzz instead of fuzzywuzzy #72

Closed maxbachmann closed 4 years ago

maxbachmann commented 4 years ago

FuzzyWuzzy is GPLv2 licensed which would force you to licence the whole project under GPLv2. I had the same problem on one of my projects and so I wrote rapidfuzz which is implementing the same algorithm but is based on a version of fuzzywuzzy that was MIT Licensed and is therefor MIT Licensed aswell, so it can be used in here without forcing a License change. As a nice bonus it is fully implemented in C++ and comes with a few Algorithmic improvements making it between 5 and 100 times faster than FuzzyWuzzy.

giulionf commented 4 years ago

Hey, thanks alot for your pull request. I'll check out your suggestion asap! Sorry for my late response.

giulionf commented 4 years ago

This look super promising. Thanks alot!

maxbachmann commented 4 years ago

You might want to go with the latest version which is 0.7.6