giuliowaitforitdavide / recsyslearn

GNU General Public License v3.0
7 stars 0 forks source link

`InvalidValueError` for `-1` in feature dataframe #13

Closed mmosc closed 1 year ago

mmosc commented 1 year ago

Maybe we can throw an InvalidValueError (choose the name that in your opinion matches it the best) if a -1 is already present in the column. I know it's a corner case but it could be a good practice. To keep the same level of coverage you also have to test this Error case

_Originally posted by @giuliowaitforitdavide in https://github.com/giuliowaitforitdavide/recsyslearn/pull/12#discussion_r944290983_