giuliowaitforitdavide / recsyslearn

GNU General Public License v3.0
7 stars 0 forks source link

Allowed number of groups for ActivitySegmentation #22

Closed mmosc closed 1 year ago

mmosc commented 1 year ago

Hi!

As discussed, we should consistently define the number of allowed groups for the ActivitySegmentation. The code only returns two groups, hence we should:

  1. Change the docstring
  2. Change the raise
  3. Document this feature in the docstring: We could change this to The proportion of users wanted for every group. Its length should be either 1 or 2.. Notice the change from interaction to user, as well.

Cheers! Marta

giuliowaitforitdavide commented 1 year ago

Right now I think that fix the docs and the docs could be better. Should we think about adding this feature (using more groups) later?

mmosc commented 1 year ago

Yes, I agree. I guess you meant fix the code and the docs (without extending the number of groups).

giuliowaitforitdavide commented 1 year ago

Yep, done