search

giuliowaitforitdavide / recsyslearn

GNU General Public License v3.0
7 stars 0 forks source link

Align all the metrics return values, now returned per user or per group #36

Closed giuliowaitforitdavide closed 10 months ago

giuliowaitforitdavide commented 1 year ago

Closes #32

giuliowaitforitdavide commented 1 year ago

Thank you for your changes :) I think we should

  • make sure that the user understands that the dataframes returned by KL and Entropy have to be summed, and not averaged, as for instance Novelty or NDCG. Maybe we should extend the docstring? Additionally, there are some things/inconsistencies not clear to me, for instance:
  • why are some tests no longer inheriting from unittest.TestCase?
  • why is as context sometimes removed, but sometimes not?
  • should we change if np.sum(proportions * 10) / 10 != 1 everywhere?

About the first point, we could also provide a flag to make the end user choose if he wants the metrics to be returned per user?group or not

mmosc commented 1 year ago

Great idea! I like this solution to the first point :)

giuliowaitforitdavide commented 10 months ago

Closed because deprecated