[REQ] Filter by ratings

[vahtos]

Related to #57. It would be great if there was a way to apply more rules to what is requested. For example, filtering by rating would be very useful. Kind of like what Overcrawlerr does.

Ideally, this would include ratings from various sources (Rotten Tomatoes, TMDB, Trakt, IMDB, etc.), but the easiest to implement is probably TMDB considering the existing integration. It should also consider how many review/votes were aggregated to form that score.

A couple of things that would need to be considered:

• What if the review source does not include that show/movie?
  • Maybe have a setting for each filter of how to handle that (count it as a pass or fail of the filter condition).
• API keys would be needed for each source used.
  • Adjust install instructions
  • Handle case where a rule exists for source which has no API key (avoid this causing an error in the CRON process and preventing other rules applying, or any suggestions from being added)

Example rules as they might appear in config.yaml:

FILTERS:
    - type: rating
      source: tmdb
      threshold: 75
      minimumVotes: 50
      failOnMissing: true

   -  type: rating   
      source: imdb
      threshold: 7.5
      minimumVotes: 100
      failOnMissing: false

[giuseppe99barchetta]

Hi @vahtos! Thank you for the suggestions 🙂

I've pushed an update to the nightly tag that includes some of these changes. Could you help test it out and let me know how it works?

[vahtos]

WOW! That was so fast. It works for me, however a couple of notes:

• The placeholder values on the inputs suggest to me that they are the default values if unset. So, I didn't set the Release Year initially, which broke suggestions. Clicking Run Now failed with the error:

  Error: Value error: invalid literal for int() with base 10: ''

  I would expect that similarly other values not being set will cause errors. Maybe these placeholders should be defaults, or there should be some form validation to prevent continuing with invalid configurations?

• The value for "Include content with missing rating or votes" toggle gets saved to the config as a boolean [as _FILTER_INCLUDE_NORATING] but the code expects a string. This causes suggestions to fail with the error:

  Error: Unexpected error: 'bool' object has no attribute 'lower'

• This is unrelated to this ticket (I can file another if you'd prefer), but I had an issue last night where requests were made in Overseerr (and thus auto-approved) with the admin account (it must have used the API Key), even though I have it set to log in with an unprivileged user so that requests should require approval. To remedy this, I had to edit the configuration, add the API Key [so that I could set the login credentials] and then remove the API Key to continue.
  • I think the solution here is that API Key should not be required for Overseerr/Jellyseerr, allowing users to specify a specific account OR an API key. This setup does appear to work, at least when I use the Run Now button. I'm not sure if there is some difference to running it that way vs. the way the CRON job runs it?

[giuseppe99barchetta]

Hi @vahtos! Thank you so much for your detailed feedback and testing. It’s incredibly helpful for the development of this project!

I’ve pushed an update to the nightly tag that includes several fixes and improvements. I’ve also added a new field to allow selecting the original language of the content, with support for multiple language filters.

I’d love to hear your thoughts on it!

[vahtos]

Hi @giuseppe99barchetta thank you for your time in working on this! I originally retested without pulling the new image... that's why you should never test before coffee :)

The issue of the bool being expected to be a string still exists, even after pulling the new image, though the screenshot here is from before updating the image.

Data type issue in how this toggle is saved (saved as bool, expected to be string)

[giuseppe99barchetta]

Hi @vahtos, thanks for the report! It looks like you're not on the latest nightly version. It seems to be the same one from yesterday. Could you try pulling the latest update?

[vahtos]

Hi @vahtos, thanks for the report! It looks like you're not on the latest nightly version. It seems to be the same one from yesterday. Could you try pulling the latest update?

Yes, sorry about that. I've updated the previous comment.

[giuseppe99barchetta]

Hi @vahtos, thanks for the report! It looks like you're not on the latest nightly version. It seems to be the same one from yesterday. Could you try pulling the latest update?

Yes, sorry about that. I've updated the previous comment.

Have you encountered any other issues? Anyway I pushed the fix for "Bool object has no attribute 'lower'" error right now :)

[vahtos]

Not related to this ticket, no. I confirmed the rating threshold and vote count seem to be working (all suggestions within the values I set). All of the suggestions also followed the other filter settings I put, but though this is a small sample size.

[giuseppe99barchetta]

Not related to this ticket, no. I confirmed the rating threshold and vote count seem to be working (all suggestions within the values I set). All of the suggestions also followed the other filter settings I put, but though this is a small sample size.

Great to hear the filters are working as expected! I'll plan to release this update soon. Just want to solve the duplicate request bug first. Thanks again for your feedback and testing!