Codecov Report

Merging #192 (339e050) into main (9a35dff) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          17       17           
  Lines        1669     1669           
=======================================
  Hits         1501     1501           
  Misses        168      168

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

pat-s commented 2 years ago

@christophM

I've compiled all NEWS and made minor (stylistic) changes to make CRAN happy. Win builder check is pending.

Please do not merge yourself, this release process is semi-automated via {fledge}. Once all checks are good and I run fledge::release(), you'll get an email for the CRAN upload.

LMK if there's anything left you'd like to change/include.

pat-s commented 2 years ago

@christophM Win-builder reports

Found the following (possibly) invalid DOIs:
  DOI: 10.1214/07-AOAS148
    From: DESCRIPTION
    Status: Internal Server Error
    Message: 500

While I think this is a false-positive, we will get an automated rejection when submitting from my experiences. I've tried multiple times but the issue persists. I think it might be still worth trying and maybe we can argue manually...

christophM commented 2 years ago

Thanks a lot! Looking good so far.

The DOI warning seems odd. Because the DOI is valid, and there was no change in the DESCRIPTION since last time.

pat-s commented 2 years ago

The DOI warning seems odd. Because the DOI is valid, and there was no change in the DESCRIPTION since last time.

Yes, but these things happen quite often.

I'll do another run on win-builder, if not, we should still aim for a release and you then just have to argue with a human :)

pat-s commented 2 years ago

@christophM Release done, you should have gotten a mail to upload to CRAN.

christophM commented 2 years ago

I've received it. Thanks and fingers crossed 🤞

christophM commented 2 years ago

I already got an answer from CRAN:

Please use a serious version number such as 0.11.0 or 0.12.0 for as software release

I guess we should make it 0.11.0 then? With the new fledge process I am not sure how to proceed. Just update the version and push to this branch?

I also got the the NOTE about the doi, but this wasn't further commented.

pat-s commented 2 years ago

It should have been 0.11.0. - sorry, I overlooked this. Not sure how this slipped through.

I've issued another release (and yes, at this stage it's just fledge::release()).

pat-s commented 2 years ago

@christophM You should have gotten another release mail 6 days ago. Could you give a quick update on what the status is? Appreciated! :)

pat-s commented 2 years ago

ping @christophM :)

christophM commented 2 years ago

Thanks for the reminder.

Yes, I got this one:

thanks, package iml_0.11.0.tar.gz is on its way to CRAN.

pat-s commented 2 years ago

🎉 Thanks! (I even forgot to look up the presence on CRAN myself, sorry for that!

christophM commented 1 year ago

Yes, I got this one:

thanks, package iml_0.11.0.tar.gz is on its way to CRAN.

Patrick Schratz @.***> schrieb am Mi., 18. Mai 2022, 09:21:

@christophM https://github.com/christophM You should have gotten another release mail 6 days ago. Could you give a quick update on what the status is? Appreciated! :)

— Reply to this email directly, view it on GitHub https://github.com/christophM/iml/pull/192#issuecomment-1129660827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMOOZFE7NSXBU7DWLMXWPLVKSK6ZANCNFSM5VHH7GWQ . You are receiving this because you were mentioned.Message ID: @.***>

giuseppec / iml

CRAN release v0.11.0 #192

Codecov Report