giuspen / cherrytree

cherrytree
https://www.giuspen.net/cherrytree/
Other
3.38k stars 461 forks source link

CherryTree process needs to be killed on Debian shutdown #2357

Open zounp opened 1 year ago

zounp commented 1 year ago

CherryTree process needs to be killed the hard way on Debian shutdown. CherryTree does not shutdown gentely.

Version, Operative system Debian 12 Bookworm 12.1 CherryTree version 0.99.48

Describe the bug When shutting down Debian Debian stalls on: "Job session-5.scope/stop running (16s / 1min 29s) From journalctl of the session shutdown; sep 21 20:07:15 hostname systemd[1]: session-5.scope: Killing process 1951 (cherrytree) with signal SIGKILL.

To Reproduce Install CherryTree on Debian 12 Bookworm 12.1 In CherryTree preferences > Miscellaneous set on:

giuspen commented 1 year ago

Please download and install the latest version of Debian 12 package first https://www.giuspen.net/cherrytree/#downl and report if the bug is still there

zounp commented 1 year ago

Installed https://www.giuspen.net/software/cherrytree_1.0.1-2~Debian12_amd64.deb Thanks for having a .deb file available. The issue persists.

giuspen commented 1 year ago

With the default desktop, gnome, the system tray is not supported, which desktop are you using?

For testing purpose, can you temporarily disable the system tray completely and tell me if cherrytree still needs to be killed the hard way on poweroff?

zounp commented 1 year ago

I am using Xfce version 4.18 "disable the system tray completely" will do that later and hope it is not going to break anything. For now I'll first test disabling the systemtray in CherryTree.

giuspen commented 1 year ago

Another test you can do is to run cherrytree from a terminal, with your usual settings (systray on), on another terminal then run killall cherrytree Is cherrytree closing gracefully or not? Are there error prints on cherrytree's terminal?

zounp commented 1 year ago

$ cherrytree [2023-09-26 15:06:06.387] [ ] [debug] /home/user/.config/cherrytree/config.cfg parsed [2023-09-26 15:06:06.453] [ ] [debug] autosave is started [2023-09-26 15:06:06.553] [ ] [debug] Node name: voip configuratie $ killall cherrytree [2023-09-26 15:06:25.153] [ ] [debug] kill_callback_handler 15 Nice shutdown of CherryTree.

What is: "Node name: voip configuratie"? Does not seem to be related to CherryTree to me.

And, I disabled the "Enable System Tray Docking" in the CherryTree settings. CherryTree shutsdown nice when the system is powered off.

giuspen commented 1 year ago

So it doesn't shutdown nicely only if the systray is on? Can you show me a killall with the systray on? Can you also check if the icon on the systray disappears after that? May be something specific in xfce as I haven't seen in cinnamon desktop

zounp commented 1 year ago

So it doesn't shutdown nicely only if the systray is on?

Indeed.

[2023-09-26 21:21:32.952] [ ] [debug] /home/user/.config/cherrytree/config.cfg parsed [2023-09-26 21:21:33.018] [ ] [debug] autosave is started

$ killall cherrytree

[2023-09-26 21:21:43.604] [ ] [debug] kill_callback_handler 15 The icon has disapeared.

giuspen commented 1 year ago

It is weird, if you can kill nicely (which is what the os does at shutdown) and it closes completely (both in terminal and systray icon gone), that shouldn't block the shutdown. Anyway I'll give it a try on an xfce when I get the chance and see if I can reproduce.