search

giuspen / cherrytree

cherrytree
https://www.giuspen.net/cherrytree/
Other
3.38k stars 461 forks source link

Very slow find by node name since updating to 1.0.4 #2408

Closed metal450 closed 5 months ago

metal450 commented 9 months ago

On both Windows & Linux, since updating from 1.0.2 to 1.0.4, searching by node name has become very noticeably slower. Previously it would find the node more or less instantly (you type Ctrl+T, type the name, hit enter, and the result window pops up more or less instantly). Now after hitting enter it goes through a lengthy progressbar, more similar to as if I were searching through full node content. After the first time I search by node name it does seem to be a bit faster during follow-up searches, but previously, I never had to wait for search by node name at all.

Using a "multiple files" db. Tree size is 1559 nodes.

giuspen commented 9 months ago

Thanks for reporting @metal450 I understand, this has been caused by the additional checks that I introduced to support losing access to the open document without crashing. I can certainly optimise when only searching for node name and tags so restore the previous speed. I'll get back.

giuspen commented 9 months ago

I should have fixed this and the speed of searching in nodes names only should be again as before v1.0.2. I can create 1-2 packages for you if you wish to try yourself

metal450 commented 9 months ago

If you'd like me to test, sure, happy to. If you're just doing it for my benefit, no worries - I rolled back to 1.0.2, so I can just wait until the next release, assuming it isn't super far off :)

giuspen commented 9 months ago

Cheers @metal450 - the next release 1.1.0 will be in 1 to 2 months unless critical issues are found - in that case I will issue 1.0.5 earlier

metal450 commented 9 months ago

Sounds good!

metal450 commented 6 months ago

Just updated to 1.1.0; Ctrl+T now never returns any results (it always says 0 matches).

giuspen commented 6 months ago

Sorry about that I will release a fix in a few days

giuspen commented 6 months ago

This should be now fixed. If you could try the test build from https://www.giuspen.net/cherrytree/#testing (called 1.1.0+5) and report if that works as expected or still has issues it would be very useful

metal450 commented 6 months ago

Yup, search works as expected :)

Just one small observation: there seems to be a new graphical glitch thing - upon the search finishing, there's a strange bar across the bottom of the notes area. It disappears as soon as you focus in the text area, change to another search result, or do anything really. Like this: 2024-03-23 18 17 52

Functionally though, it's back in order :)