giuspen / cherrytree

cherrytree
https://www.giuspen.net/cherrytree/
Other
3.38k stars 461 forks source link

xml-stripblanks WARNING when building Debian package #2410

Closed DennisRasey closed 9 months ago

DennisRasey commented 9 months ago

Version, Operative system Debian Testing (docker image debian:testing-slim). Cherrytree 1.0.4 & latest git version

Describe the bug xml-stripblanks message when building Debian package

To Reproduce

./build.sh deb

Gives following WARNING (does not appear to be fatal)

xml-stripblanks preprocessing requested, but XMLLINT is not set, and xmllint is not in PATH

Resolution apt install libxml2-utils

Notes/Thoughts Since this appears to only be a WARNING & still results in a successful build; do we gain anything by installing libxml2-utils?

giuspen commented 9 months ago

The warning is generated here https://github.com/giuspen/cherrytree/blob/master/scripts/gresource_to_c.py in fact I don't think we gain in stripping the XML blanks as a C file is generated and used at the end of the process but the warning is annoying. I'll check to either disable the stripping or add the dependency

giuspen commented 9 months ago

Actually I'm wrong as the .SVG files are .XML We should add the dependency

giuspen commented 9 months ago

Could you be so kind to open a PR as you did for file? :)

DennisRasey commented 9 months ago

Created a PR for this

2415