search

giuspen / cherrytree

cherrytree
https://www.giuspen.net/cherrytree/
Other
3.3k stars 458 forks source link

Possible Preference Settings Bug #2418

Open timcrouse opened 6 months ago

timcrouse commented 6 months ago

Version, Operative system Win 11

Describe the bug Not sure if this is the intended work-flow but there may be a bit of an oddity in the preference settings. If you have multiple notes, if you want to change the line number background you have to set the line number background and then toggle the color of the current line background to get it to take effect. You have to do this on each note.

I should point out my goal was not to change the Line Number Background but rather to set the border line color that separates the top of the editor and the toolbar. The only way I found to do this was by setting the Line Number Background Color.

To Reproduce

PREFERENCE >> LINE NUMBER BACKGROUND COLOR TOGGLE CURRENT LINE BACKGROUND COLOR TO GET LINE NUMBER BACKGROUND COLOR TO TAKE EFFECT

Screenshots If applicable, add screenshots to help explain your problem.

giuspen commented 6 months ago

Hi @timcrouse is this happening with v1.0.4? What do you mean with multiple notes, is it multiple cherrytree windows / more than one document?

timcrouse commented 6 months ago

Yes it is happening in 1.0.4.

By multiple notes I meant multiple text documents.

To rephrase the odditiy:

Say you want to change the editor window border line color. You get access to this by changing the preference LINE NUMBER COLOR.

After you change the color in the preference dialog you have to select each note in the tree. Open the preference dialog and toggle the current line color. If you do not do this the editor border edge line color stays as the original defined color.

Hope that helps Best Regards -Tim C.

On another note ( I will open a separate request) would you consider updating the the FIND / REPLACE dialog to toggle an advanced mode? The intent is to simplify the options. As it it currently is displayed many advanced options are displayed.

A simpler format would be:

  1. Inherently only find and replace items in an active selection, meaning if an area is selected that is what is targeted and only that area. >> in BASIC mode display two radio buttons "DOCUMENT, SELECTED", this would allow the user to override the selection on-the-fly as not to have to restart the process (close the dialog and unselect the text).

  2. Add the ability to use the mouse on the editor while the find / replace dialog is open so the user can copy text to be used in the find / replace dialog. As it is if you have an area selected to perform a find and replace on all that text is automatically placed in the top search entry text box.

giuspen commented 5 months ago

Hi @timcrouse I think I understand your flow but it's simply not happening to me. v1.0.4, Windows 11. I am in a rich text node, I have the line numbers visible, I open the preferences dialog tab theme and edit user-1, change "Line numbers background". That is applied immediately to all the rich text nodes for me with no other action needed. Maybe you can send me your config.cfg so I can try to reproduce using your configuration

timcrouse commented 5 months ago

Is the text CAVAS border color (the thin line) changing?

The text changes color, it's the editor thin border line thaqt is not changing color until I go thru the other steps.

-tim C.

From: Giuseppe Penone @.> Sent: Wednesday, January 17, 2024 5:12 PM To: giuspen/cherrytree @.> Cc: timcrouse @.>; Mention @.> Subject: Re: [giuspen/cherrytree] Possible Preference Settings Bug (Issue #2418)

Hi @timcrousehttps://github.com/timcrouse I think I understand your flow but it's simply not happening to me. v1.0.4, Windows 11. I am in a rich text node, I have the line numbers visible, I open the preferences dialog tab theme and edit user-1, change "Line numbers background". That is applied immediately to all the rich text nodes for me with no other action needed. Maybe you can send me your config.cfg so I can try to reproduce using your configuration

— Reply to this email directly, view it on GitHubhttps://github.com/giuspen/cherrytree/issues/2418#issuecomment-1897070436, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGW34IPCMMP7NDALZLR6KIDYPBEDFAVCNFSM6AAAAABBFUERDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJXGA3TANBTGY. You are receiving this because you were mentioned.Message ID: @.***>

giuspen commented 5 months ago

The border line colour is changing too, yes. Maybe a couple of screenshots here would clarify. I'm also not sure with what you mean by toggling the current line colour, is it just selecting again the same value?