search

giuspen / cherrytree

cherrytree
https://www.giuspen.net/cherrytree/
Other
3.29k stars 457 forks source link

Search in Current Node & Find in Multiple Nodes... not find some alternative numbers or text randomly #2444

Closed VarinderMick closed 3 months ago

VarinderMick commented 4 months ago

Version, Operative system Windows 7

Describe the bug I try to use Both > Search in Current Node & Find in Multiple Nodes but results are not normal see screenshots attached.

To Reproduce please paste following text in some new nodes

999* 777777777777 777777 54545454 343434 545454 9999999999999999999999 700078967007896 y t y ey t yt r ytr yt opopoppoopoppopopoppopoppopopppooopopop 11 opopoppioiuioppopopopoooppopo

I found that above error in results are due to the presence of Table, image, latexbox, Codebox in RTF node. (update to recreate the error)

Steps to reproduce the behavior:

create RTF node with above text and must have a Table, or image, or latexbox, or Codebox (update to recreate the error)

  1. use Both > Search in Current Node & Find in Multiple Nodes
  2. Find 54 , 77, 777, op, 999
  3. See error results shown in screenshots and
  4. also in table the results are not as per data repeated in table see next post for this.

Screenshots If applicable, add screenshots to help explain your problem. pic-000214 pic-000215 pic-000216 pic-000217 part 1 pic-000217 part 2

VarinderMick commented 4 months ago

Updated post: ----------------- I found that above error in results are due to the presence of Table, image, latexbox, Codebox in RTF node. if I remove all of these then search results are fine. And in table the search is not as per data repeated in table as I try to find 'fg' it shows only one but in table are 3 'fg'

table result not ok errors are due to these without table etc results are fine

giuspen commented 4 months ago

Hi @VarinderMick are you using latest version 1.0.4? Could you attach a test document to the ticket or send me privately? (mail in Help->About dialog)

VarinderMick commented 4 months ago

Hi Giuspen, Thanks for your quick response. I am going to send you the file by email as unable to attach here. Regards imvm FYI: yes I am using latest 1.0.4 portable. the file is attached for your testing. I paste the same text block before each of the elements (Table, latexbox, Codebox) image not used as you add image yourself after first block and paste text after it.

The text document is attached for your investigation. and Thanks a lot for CherryTree

Text block is as below: (Random text)

999* 777777777777 777777 54545454 343434 545454 9999999999999999999999 700078967007896 y t y ey t yt r ytr yt opopoppoopoppopopoppopoppopopppooopopop

opopoppioiuioppopopopoooppopo

VarinderMick commented 4 months ago

Hi Giuspen,

Please find the attached test file. and my suggestions/(request to add features) are :

  1. add file or folder path by drag and drop.
  2. add picture (show pictures like jpg png) from hard disk picture file path/link (not like embedded in Cherrytree)

I try to test the software to use, I use it long long ago for short periods of time. now I try to use it and test to see is it working for search and found these concerns. But I like the most is the table feature which is very good as it includes sorting and add OR move row columns as required. Only issue with table is with search in table data needs to be highlighted as rich text but work around is there as I found copy table in a text node and search 😉 .

Thanks, Varinder

From: Giuseppe Penone @.> Sent: Friday, February 23, 2024 3:34 AM To: giuspen/cherrytree @.> Cc: Varinder Mohan @.>; Mention @.> Subject: Re: [giuspen/cherrytree] Search in Current Node & Find in Multiple Nodes... not find some alternative numbers or text randomly (Issue #2444)

Hi @VarinderMickhttps://github.com/VarinderMick are you using latest version 1.0.4? Could you attach a test document to the ticket or send me privately? (mail in Help->About dialog)

— Reply to this email directly, view it on GitHubhttps://github.com/giuspen/cherrytree/issues/2444#issuecomment-1960393353, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5EJB6UIYNNGCKBFVDHWFI3YU66IPAVCNFSM6AAAAABDUCQAI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGM4TGMZVGM. You are receiving this because you were mentioned.Message ID: @.***>

giuspen commented 4 months ago

Ho @VarinderMick sorry I'm a bit slow to follow up because I'm completing v1.1.0 changes before writing to the translators. I haven't received an email can you look in help--about dialog for my private email and send me the test file?

giuspen commented 4 months ago

Thanks for your report @VarinderMick and for submitting the test document. This is now fixed, the fix will be in upcoming v1.1.0. If you would like to test the fix before the new release is issued and report feedback please let me know and I will prepare a test portable windows version

VarinderMick commented 4 months ago

Thanks @giuspen ! sure you can provide me the test portable windows version to test upcoming v1.1.0. I will be happy to test. (late as I not check/see my emails daily)

giuspen commented 4 months ago

Thanks @VarinderMick please download https://www.giuspen.net/software/cherrytree_1.0.4.0+63_win64_portable.7z - this is effectively v1.1.0 pre-release - and report if it works as expected now

VarinderMick commented 3 months ago

Thanks @giuspen, I just check it for quick, it now search ok but not inside table (even 1 table if it contain same data value in different cells) while I put 2 tables it does not get the results for multiple table as well inside single table and not highlight the second table location properly, and latex block not inserted with this test version, get error for dvipng.exe..... libkvzaar-z.dll not found.

table search location and data highlight error

Pic-000641 on 07-03

VarinderMick commented 3 months ago

Hi, @giuspen, latex block not inserted got a triangle there and table search line position highlight and all data inside table not work properly. latest results. table in row 28 but not in 31 and full table is in one row, so may be it highlight all 3 67 in table one by one somehow. if I make a longer table I will never find any thing as it show one line result without highlight.

pic-000224 pic-000225

giuspen commented 3 months ago

Thanks @VarinderMick I fixed the missing dll and re-uploaded the portable bundle. Not highlighting the table cell and also not distinguiching table cells is a known issue also reported in https://github.com/giuspen/cherrytree/issues/2155 I have to support that

VarinderMick commented 3 months ago

Hi, @giuspen, Thanks for update but still have issue as per screenshots if tables like shown below

not ok if tables search not ok if table is there

latex is ok but find feature not, inserted in line#14 but result is not nice, shows only one table instead of two and that even highlight at wrong location issue with tables

giuspen commented 3 months ago

Nice testing @VarinderMick I will come back with a fix. I decided to implement also the search inside of the table cells and code boxes as you are so kind to test thoroughly I will use your help, likely delaying the release of v1.1.0 of about a week

VarinderMick commented 3 months ago

Hi, @giuspen, Thanks for your kind response and happy to test, please take a look at issue-3 of #2454 if possible.

giuspen commented 3 months ago

please @VarinderMick test https://www.giuspen.net/software/cherrytree_1.0.4.0+pre110_win64_portable.7z where also the search in codeboxes and tables has been implemented

VarinderMick commented 3 months ago

now it perfectly search in tables also. Thanks and respect for your efforts!

(can you please take a look at #2454 to link file/url/folder/image with preview links by drag/drop at any line of note)

giuspen commented 3 months ago

Thanks for your testing @VarinderMick - I will look at the other ticket after the release which is running late