search

giuspen / x-tile

X Tile
https://www.giuspen.net/x-tile/
Other
69 stars 13 forks source link

Python errors with x-tile 3.1 an multi-monitor #12

Open toma315 opened 4 years ago

toma315 commented 4 years ago

After upgrading to 3.1 I get

$ x-tile WM = Xfwm4 Traceback (most recent call last): File "/usr/bin/x-tile", line 74, in x.reload_windows_list() File "/usr/share/x-tile/modules/core.py", line 1006, in reload_windows_list self.store.load_model(self) File "/usr/share/x-tile/modules/core.py", line 156, in load_model win_geom = support.get_geom(win_id) NameError: name 'win_id' is not defined

This looks like some new issue possibly limitted to multi monitor environments. Same happens in 3.0, 2.6 works for me, however.

Trying to fix this win_id error lead to some other error - at that stage I gave up trying to fix it myself.

oz123 commented 4 years ago

I can confirm this behaviour with multi-monitor setup.

giuspen commented 4 years ago

Unfortunately I cannot test with a second monitor at the moment but I pushed a fix that hopefully will at least move to the next error. When possible I will test myself but if you report me the issues we can still fix in hopefully few steps

oz123 commented 4 years ago

Thanks for your reply. Your latest fix helps to prevent the crash. However, windows are still only tiled in one desktop.

giuspen commented 4 years ago

Thanks @oz123 I'll try and get hold of a monitor to try myself

giuspen commented 3 years ago

should be fixed in current version

oz123 commented 3 years ago

Thanks. That works now, although it only tiles windows on the primary screen.