search

givanse / ember-cli-simple-auth-devise

:key: Authenticate to a Rails/Devise server from Ember CLI.
The Unlicense
40 stars 9 forks source link

Second login does not take user/pass into account #1

Closed winkler1 closed 10 years ago

winkler1 commented 10 years ago

Hi- Thanks for doing this example. Really useful. One thing we noticed, though-

  1. Created back-end users with seeds.rb
  2. Logged into client, great.
  3. Log out on client. Nothing is communicated back to the server.
  4. Click login on the client... enter garbage for username & password
  5. BUG: Login succeeds!

Pretty sure this is ember-simple-auth's (vendor/ember-simple-auth/ember-simple-auth-devise.js) fault, do you agree?

  /**
    Does nothing

    @method invalidate
    @return {Ember.RSVP.Promise} A resolving promise
  */
  invalidate: function() {
    return Ember.RSVP.resolve();
  },
givanse commented 10 years ago

Thanks, I just confirmed this. From your instructions, we can cross out number 4, the client will login even with empty inputs.

I'll see what else I find and report to the appropriate place.

givanse commented 10 years ago

Follow progress of this bug at: https://github.com/simplabs/ember-simple-auth/issues/201

givanse commented 10 years ago

It wasn't really a bug in ember-simple-auth-devise, but a missing configuration in Rails. The docs for ESA were updated with: https://github.com/simplabs/ember-simple-auth/issues/204