givanz / Vvveb

Powerful and easy to use cms to build websites, blogs or ecommerce stores.
https://www.vvveb.com
GNU Affero General Public License v3.0
239 stars 49 forks source link

Error saving on Page builder #141

Open Gellish opened 1 week ago

Gellish commented 1 week ago

Screenshot_23-6-2024_151836_localhost Capture

givanz commented 1 week ago

Can you please provide steps to reproduce and more details, are you using default theme or another theme? the saved page is homepage or another page, is it a newly created page from new page button or an existing page?

Until I find the cause of empty content I added some checks to avoid saving the page if there is no content to prevent the error from happening https://github.com/givanz/Vvveb/commit/ffa4f96ce9710de582eaccdc441905cd96c74f72

This is strange, saving is done with a POST request to index.php?module=editor/editor&action=save I could not find any reference to save.php that is shown in the error log.

Gellish commented 1 week ago

It works now. But got another problem if I using Blog theme is work perfectly fine if I using another theme Portio, I got problem issue 1: Error saving backup! File saved! issue 2: portio/css/custom.css is not writable!

Issue 2 solve: I try adding custom.css change become writable bash: chmod -R a+rwX /var/www/public/themes/

givanz commented 1 week ago

Thanks for feedback.

Some themes were not updated after the css editor feature was added to page builder and they are missing css/custom.css

For backup error make sure that public/themes/portio/backup folder is writable, this folder was also missing and is now included in the theme to avoid this issue.

I updated Portio to include custom.css and backup folder in the last commit https://github.com/Vvveb/portio/commit/31615c1cdb0ed23fbfe642652bd42d5872cae730

jigneshk5 commented 4 days ago

Hi @givanz Getting this error message when changing any text or logo. image Even though this folder public/themes/landing/backup has write permission: image

I have deployed the build from https://vvveb.com/download.php

givanz commented 2 days ago

Hi

Thanks for the bug report, the path to backup folder was missing a separator, it's fixed in the last commit https://github.com/givanz/Vvveb/commit/eea5684e9f51fc98035825188302be87ec390edd