search

givanz / Vvveb

Powerful and easy to use cms to build websites, blogs or ecommerce stores.
https://www.vvveb.com
GNU Affero General Public License v3.0
384 stars 82 forks source link

Third Party Cookie Consent #160

Open Shofiul-Alam opened 4 months ago

Shofiul-Alam commented 4 months ago

Need to implement third party cookie consent. Implementing https://support.google.com/chrome/a/answer/14439269?hl=en

image

givanz commented 4 months ago

I'm unable to find a page that sets 3rd party cookies to see these warnings in the console.

Can you please provide more details?

Shofiul-Alam commented 4 months ago

Hi, It happes once I load the builder page, edit something and scroll the page.

image

I found that cookie-notice plugin sloved this problem. But also I found bug in cookie-notice plugin's javascript. The following fixes needed to be implemented in notice.html from line 36.

let notice = document.querySelectorAll("#cookie-notice .toast"); if (localStorage) {

let cookie = localStorage.getItem("cookie-notice", "unset");

if (!cookie && notice && notice.length) {
    notice.forEach((i) => i.classList.add("show"));
}

}

givanz commented 4 months ago

Hi

Thanks for feedback.

It seems that the embed google maps from contact form section sets cookies that triggers these chrome warnings.

I managed to reproduce them once but now I no longer seem them in the console, maybe different google maps code loaded.