givanz / Vvveb

Powerful and easy to use cms to build websites, blogs or ecommerce stores.
https://www.vvveb.com
GNU Affero General Public License v3.0
239 stars 49 forks source link

CSS is reset with fill and borders when the font is changed #80

Closed lilianzzz closed 4 months ago

lilianzzz commented 4 months ago

CSS is reset with fill and borders when the font is changed.

If you need additional information, please write =)

https://github.com/givanz/Vvveb/assets/24529543/64692389-e96d-441d-9bd8-30d92e7a32de

givanz commented 4 months ago

Thanks for the detailed video, I managed to reproduce and fix the bug.

Please redownload latest.zip and update public/js folder and clear browser cache.

lilianzzz commented 4 months ago

Great, the css is not reset, although now the font size and other parameters from the side menu do not change =)

vivaldi_fO00v8zPCz Upd -

I tried it in a clean environment - everything is correct on it, maybe the problem is in my template

givanz commented 4 months ago

Thanks for the bug report.

I just checked the heading and the font size was set with the inline text editor, the one that shows on double click on text.

The inline text editor sets the properties with inline style on the element this has higher precedence overriding any change made from the panel that sets the property in css.

I will make some tests and see how to change the text editor to also save to css to avoid this issue.

You can use the text editor to change the font size until it's fixed.

lilianzzz commented 4 months ago

Apparently the IDs were broken, after changing the ID for the title the problem disappeared. It’s true that you have to manually enter at least something into the ID for all elements to “unstick” image

givanz commented 4 months ago

Fixed it, please update /public/js/vvvebjs/builder.js from latest.zip and clear cache.

For elements that don't have unique identifiers the css selector is generated from parent elements and it applies to all similar child elements.

Sometimes this can be useful for example if you want to change the color for all icons in the same list/section etc

When this it's not wanted it can be solved be setting a unique id.

lilianzzz commented 4 months ago

Thank you very much =). am I closing the issue?

givanz commented 4 months ago

With welcome, you can close it if it's fixed.