search

givanz / Vvveb

Powerful and easy to use cms to build websites, blogs or ecommerce stores.
https://www.vvveb.com
GNU Affero General Public License v3.0
384 stars 82 forks source link

Сustom favicon favicon in admin panel not overlap theme favicon #81

Closed lilianzzz closed 9 months ago

lilianzzz commented 9 months ago

There is an assumption that the template favicon (is it even needed at the template level?) has higher priority than the favicon in the admin settings

It’s problematic to check completely - the favicon is apparently cached at my server level and takes N-hours to change

givanz commented 9 months ago

The theme usually has a default favicon that is overwritten by site settings.

Any theme is a standalone working static html template/site and for this they have proper defaults for everything.

Html files can even be opened directly from theme folder in the browser and display properly.

This issue was caused because blink theme was missing data-v-global-site-favicon attribute on favicon element 

<link rel="shortcut icon" type="image/x-icon" href="img/favicon.png" data-v-global-site-favicon>

You can redownload the theme or add the attribute manually in index.html and clear cache.

lilianzzz commented 9 months ago

Thank you very much for the explanations. works! =)