search

givanz / VvvebJs

Drag and drop page builder library written in vanilla javascript without dependencies or build tools.
https://www.vvveb.com/vvvebjs/editor.html
Apache License 2.0
7.16k stars 1.64k forks source link

Cannot hyperlink text easily #284

Open yasmagic opened 1 year ago

yasmagic commented 1 year ago

It is very hard to select any text and hyperlink it. When the link icon is clicked, nothing happens. If there is a link already, then the option appears under "Content" block. But, it doesn't work if we try to hyperlink a text.

givanz commented 1 year ago

I changed the code to select the link element after is created to allow entering url and changing properties.

https://github.com/givanz/VvvebJs/commit/a0825e50aef5573a174e6496f6262fd5912ab0e5

yasmagic commented 1 year ago

Thank you. Also, Hyperlinking an image is very hard and nearly impossible unless we use code editor.

givanz commented 1 year ago

Thanks for the suggestion, now image component has enable link option.

https://github.com/givanz/VvvebJs/commit/90a1b3e18b42ba1358a2fecb91316b8b4aaf37d1

yasmagic commented 1 year ago

Hi @givanz, Thanks for the updates. Linking an image doesn't work properly if right panel is hidden.

image

No option for enter URL.. it shows like this on the left:

image

givanz commented 1 year ago

Hi

Can you provide more details on how to reproduce this issue? I checked image link option with right panel disabled and it works https://gofile.io/d/TUZT8O In your screenshot it looks like the .row div is selected and not the image.