givanz / VvvebJs

Drag and drop page builder library written in vanilla javascript without dependencies or build tools.
https://www.vvveb.com/vvvebjs/editor.html
Apache License 2.0
7.15k stars 1.64k forks source link

ComponentSectionContent Error after the video element update #321

Open NeilCoyne opened 1 year ago

NeilCoyne commented 1 year ago

Uncaught SyntaxError: Identifier 'ComponentSectionContent' has already been declared (at section.js:1:1)

givanz commented 1 year ago

Hi

I'm unable to reproduce this bug, can you provide more details or steps to reproduce?

It happens on demo https://www.vvveb.com/vvvebjs/editor.html also?

The component is Embed video (youtube, vimeo) or Video (native html video)?

What properties I should change for the error to show?

Can you try to disable all browsers extensions and retry? some browsers extensions sometimes interfere with page content.

NeilCoyne commented 1 year ago

Hello, Sure I just check again so I downloaded a fresh clean zip of the code added it to a local env (ampps) on local server navigated to editor.html or editor.php and I get the error .. using Chrome, FF, and edge all give same error.. tried with all extensions disabled in incognito mode same error

I am only presuming it is related to the video update to the code you added two weeks again , as this is when I saw the error. (no it is not happening on https://www.vvveb.com/vvvebjs/editor.html )

givanz commented 1 year ago

Thanks for details.

This was caused by Section component that was moved from https://github.com/givanz/VvvebJs/blob/master/libs/builder/components-elements.js into a separate file https://github.com/givanz/VvvebJs/blob/master/libs/builder/section.js and ComponentSectionContent was not deleted from components-elements.js.

It's fixed in the last commit https://github.com/givanz/VvvebJs/commit/d9e8e3a571200057a017da8aeb80adf87388cd57

NeilCoyne commented 1 year ago

Excellent thanks so much .. such great code by the way I am loving playing arround with it ;-)

givanz commented 1 year ago

Thank you