givanz / VvvebJs

Drag and drop page builder library written in vanilla javascript without dependencies or build tools.

https://www.vvveb.com/vvvebjs/editor.html

Apache License 2.0

6.86k stars 1.58k forks source link

Can't update image or svg icon if I select element in second time #345

Open ElegantSoft opened 3 months ago

ElegantSoft commented 3 months ago

If I select any image to update everything works perfectly But If I select any element then reselect any image or Icon I can't edit Image or Icons As seen in second screen All Image controls has gone if I select another element and try to select any image again.

You can reproduce issue here https://www.vvveb.com/vvvebjs/editor.html

ElegantSoft commented 3 months ago

I found the issue in css and fix it

346

givanz commented 3 months ago

Thans for the bug report, it's fixed in the last commit https://github.com/givanz/VvvebJs/commit/9e7fda542bd2ca92425908d834a2d9239ce27fb9

It was caused by a recent change to section input template to add unique id's

https://github.com/givanz/VvvebJs/commit/36d6fbdeeb293d626c5fe5b0ca6b4b7ab7a7ac56#diff-e9eb2a4d0ec0db2d1869efdc6d2557641a3fa8efbe7150ade2759ec3bcb4fa0fR1373-R1374.

ElegantSoft commented 3 months ago

@givanz Thanks for fast reply, I did the fix now in my side. I am currently doing a good product with your editor really thanks for this awesome tech <3 <3