Fixes on varintBufNum and varIntWriter

givelotus / lotus-vase

A simple reference wallet for Lotus which supports mobile devices.

GNU General Public License v3.0

4 stars 2 forks source link

Fixes on varintBufNum and varIntWriter #155

Closed limonadev closed 3 years ago

limonadev commented 3 years ago

This PR fixes the next details on the title methods:

Throws an Exception for negative values on both.

Removed unnecesary code on both:

writer.writeInt32(n & -1, Endian.little);
writer.writeUint32((n / 0x100000000).floor(), Endian.little);

Fixed flags limit comparison on varIntWriter.
Removed some unused comments and imports.

schancel commented 3 years ago

Thank you ademir. This is great. Do you have a specification to link to for this PR? I actually have never looked at how these should serialize. I just want to make sure that it works correctly. In parts of the code I mistakenly used a incorrect signed encoding of bigint, when they were always supposed to be unsigned, and I had to fix that.

limonadev commented 3 years ago

I followed the rules from this book, but also found the specification about the varint encoding/decoding for bitcoin.