search

givepulse / knowbilitywarriors

Web Accessibility Website work for Accessible Housing Austin
0 stars 1 forks source link

An element that does not have a role must reference only valid WAI-ARIA global properties. #38

Open mehdia opened 10 years ago

mehdia commented 10 years ago

Page: Home, About AHA, Our Housing, Our Stories, Learn More, Contact Us, Donate

On Elements: /html/body/ul/li[3]/a /html/body/ul/li[6]/a /html/body/ul/li[7]/a

Solution: An element that does not have a role must reference only valid WAI-ARIA global properties to enable compatibility with assistive technologies.

For example, the following element does not have a WAI-ARIA role and references a valid aria-labelledby WAI-ARIA global property. Unlike WAI-ARIA widget properties, a global property may be applied to any element.

<div id="label2">A label:</div> <div aria-labelledby="label2">...</div>
slauriat commented 10 years ago

Can you clarify this? It looks like it says the link "About AHA!" (and a couple of others) needs an extra something, but the example doesn't help a whole lot.

mehdia commented 10 years ago

Seems like the aria rule : aria-expanded="true" is invalid.

Removing this will take care of this error

slauriat commented 10 years ago

Just did an audit with it open and it passes. That looks like a valid attribute for that element. Removing that attribute would remove the indication to assistive technology of the open/closed state.

mehdia commented 10 years ago

It will be valid when you use the appropriate role with it, in this case it would be role="button". ref: http://www.w3.org/WAI/PF/aria/roles#link

slauriat commented 10 years ago

Since we use the link as a link, I don't want to add button.

christosptr commented 10 years ago

I agree

On Sun, Dec 8, 2013 at 8:21 AM, slauriat notifications@github.com wrote:

Since we use the link as a link, I don't want to add button.

— Reply to this email directly or view it on GitHubhttps://github.com/givepulse/knowbilitywarriors/issues/38#issuecomment-30065154 .

Kind Regards Christos Petrou

PLEASE CONSIDER THE ENVIRONMENT BEFORE PRINTING THIS EMAIL. "I personally measure success in terms of the contributions an individual makes to her or his fellow human beings." "Never doubt that a small group of thoughtful, committed citizens can change the world; indeed, it's the only thing that ever has." Margaret Mead (1901-1978)

georgeluc commented 10 years ago

is this open or close?

christosptr commented 10 years ago

I will have a look

On Mon, Feb 17, 2014 at 11:01 AM, George Luc notifications@github.comwrote:

is this open or close?

— Reply to this email directly or view it on GitHubhttps://github.com/givepulse/knowbilitywarriors/issues/38#issuecomment-35220670 .

Kind Regards Christos Petrou

PLEASE CONSIDER THE ENVIRONMENT BEFORE PRINTING THIS EMAIL. "I personally measure success in terms of the contributions an individual makes to her or his fellow human beings." "Never doubt that a small group of thoughtful, committed citizens can change the world; indeed, it's the only thing that ever has." Margaret Mead (1901-1978)