Is it OK to modify the existing database tables?

[ixai]

The login mechanism depends on a token. Since the app is small enough, I could simply add a global dictionary that maps auth tokens and users. In the spirit of good practices I wouldn't want to do that since it's not scalable. Unless of course, you tell me that it's OK.

I see other two options:

• create a new table that works as the dictionary. Since we don't actually have a logout endpoint it will grow until truncated;
• modify the existing users table to add a token column. This way there's a single value that will be overwritten with every new login.

Is it OK if I modify the existing table?

[ixai]

I went with creating a new table and keeping it as short as the number of users who've logged in. Even if it's not maintainable I believe it's a good compromise for the test at hand.

[shunjikonishi]

Hi @ixai

Thank you for taking our test.

I've verified your app pass the all of tests.
And I think your opinion in answer.md is very good to the point. Your answer is excellent.

Adding a new table is no problem. Because it shows you are considering about scale out.

Though I didn't intend to demand about scale out in this question, I think it is one of good point of your answer.

I made this test based on the service we shipped last month. This service still has several problems exactly what you mentioned.

We are seeking the maintainer of this app.
So if you join us, maybe your first work will be to improve this app.(Currently using FuelPHP)

The other hand, we are planning to make a new service for engineers to provide online skill check test.
I'm a leader of this project.

This test was an experimental case of our new service.

What did you feel about this test?
If you have any opinion about this test, please let me know.

Regards.

Shunji Konishi

[ixai]

@shunjikonishi

I found it very interesting and fun, especially since it's different from the average interview where you have to solve one or two algorithms in one hour.

The api-first-spec is an interesting tool, automated API testing is one of the things I've struggled with the most recently. I was recently looking into RAML for API documentation and I can imagine how specs could be converted from one to the other and some test cases auto-generated.

I hope we can talk some more over Skype (or in person! :).

[shunjikonishi]

@ixai

About RAML, I've known that, but it seems not active.
So, I didn't use it.

I developed api-first-spec to describe API spec as a test.
In my experience, most project had their API specification as a document, these were not maintained enough.

If the spec is a document as same as a test, it might be maintained. That is the reason why I developed it.

At first, we will apply it to our current service. And then I'm considering how to use it in our new service(Skill check platform).

If you have interest with such a testing framework, you might fit with our company.

Maybe next step will be skype with me. I'll suggest some time later.