givery-technology / sample-test

13 stars 23 forks source link

Implemented #14

Closed javiercontrerasl closed 9 years ago

javiercontrerasl commented 9 years ago

Dear,

I have developed this solution in NodeJS. However, I could not run the spec/test in my machines (Windows and Ubuntu). I got a "econnrefused" error in Ubuntu and an "uncaught assertion error: response isn't success" in Windows. So, after checking what is going on and I create my own test using part of your routine with mocha supertest and should.

https://github.com/javiercontrerasl/sample-test/tree/simple-test/base

Regards, Javier Contreras.

shunjikonishi commented 9 years ago

Hi @javiercontrerasl Thank you for taking our test.

I checked your code.

Your implementation seems to good. But in this test, the most important thing is to pass all our original api-first-spec tests.

You shouldn't make your original tests, even if these are better than original.

I guess the reason why you faced "econnrefused" error is wrong port number of config.json. I could run original tests by changing config.json.(with ubuntu on VirtualBox. I have no idea about windows error.)

Please try it again. If you have any questions about it. Please write it here.

Best.

Shunji Konishi

javiercontrerasl commented 9 years ago

Hi Shunji,

Thank you for your text and testing the app.

I understood about my own test, I apologize about it, but I was interested in to know if the application has issues or not and I could not know with the original test.

I spent half day trying to resolve the problem on Ubuntu. The address and port were correct. Somebody was talking about socket configuration, but did not work as well.

Thank you once again.

Regards, Javier Contreras.

shunjikonishi commented 9 years ago

@javiercontrerasl

Well.. I still think this is the problem around port.

Several candidates already pass this test, so I think the setting of this test is correct, and we provide enough information to run it.

I think that it is one of the skills necessary for an engineer to deal with such a problem. I believe you can solve the problem by yourself.

Thank you once again for taking our test.

Best.

Shunji Konishi