search

givery-technology / sample-test

13 stars 23 forks source link

Implemented #15

Closed ikarigeorge closed 9 years ago

ikarigeorge commented 9 years ago

Hello,

I have implemented the test in Node.js You can find it here: https://github.com/ikarigeorge/sample-test

It is necessary to install the required modules with "npm install" Then, start the server with "node app.js" Finally run the test "mocha spec/*.js"

Greetings,

Jorge Avante Reyes

shunjikonishi commented 9 years ago

Hi @ikarigeorge Thank you for taking our test.

I verified your implementation pass all of the tests. Great.

However, I think it is better to remove db connection settings from dao classes.
I had to fix 3 files to run your app with my database. It's not good.

We'll contact you later by Justa.

Thanks.