Closed sainies closed 9 years ago
Hi @sainies Thank you for taking our test.
I just downloaded your code. And run test. (mocha spec/*) But it failed 12 tests.
Please check it again.
Shunji Konishi
Hello Shunji Konishi, I corrected the app, all tests seam to pass.
@sainies
It still fails some tests...
mr shunji,
should i test it directly on github or i can test it on my laptop also?
Mershunj-sani,
Can i apply for a internship to your company.
Best Regard, Jhunnel Ordinario
On Apr 20, 2015, at 4:49 PM, Shunji Konishi notifications@github.com wrote:
@sainies
It still fails some tests...
— Reply to this email directly or view it on GitHub.
@JhunnelOrdinario The issue of your question is #6. This issue is for other candidate.
If you have any idea or question, please write to #6.
Shunji
Hello Shunji Konishi, I see some sql-fixtures warnings which may be affecting the tests, although tests do pass.
WARNING, sql-fixtures: it looks like attends does not have a singular primary key column. This means sql-fixtures needs to make a guess to return this record. You may get unexpected results. See: http://city41.github.io/node-sql-fixtures/#no-primary-key-warning
136 passing (749ms)
@sainies Thank you for reporting this.
Though this is not affected to test result, I'll investivate how to avoid this.
Fixed the SQL for the company events listing.
@sainies
Your implementation still doesn't pass all tests....
https://github.com/sainies/sample-test.git