givery-technology / sample-test

13 stars 23 forks source link

implemented #5

Closed sainies closed 9 years ago

sainies commented 9 years ago

https://github.com/sainies/sample-test.git

shunjikonishi commented 9 years ago

Hi @sainies Thank you for taking our test.

I just downloaded your code. And run test. (mocha spec/*) But it failed 12 tests.

Please check it again.

Shunji Konishi

sainies commented 9 years ago

Hello Shunji Konishi, I corrected the app, all tests seam to pass.

shunjikonishi commented 9 years ago

@sainies

It still fails some tests...

JhunnelOrdinario commented 9 years ago

mr shunji,

should i test it directly on github or i can test it on my laptop also?

JhunnelOrdinario commented 9 years ago

Mershunj-sani,

Can i apply for a internship to your company.

Best Regard, Jhunnel Ordinario

On Apr 20, 2015, at 4:49 PM, Shunji Konishi notifications@github.com wrote:

@sainies

It still fails some tests...

— Reply to this email directly or view it on GitHub.

shunjikonishi commented 9 years ago

@JhunnelOrdinario The issue of your question is #6. This issue is for other candidate.

If you have any idea or question, please write to #6.

Shunji

sainies commented 9 years ago

Hello Shunji Konishi, I see some sql-fixtures warnings which may be affecting the tests, although tests do pass.

WARNING, sql-fixtures: it looks like attends does not have a singular primary key column. This means sql-fixtures needs to make a guess to return this record. You may get unexpected results. See: http://city41.github.io/node-sql-fixtures/#no-primary-key-warning
136 passing (749ms)
shunjikonishi commented 9 years ago

@sainies Thank you for reporting this.

Though this is not affected to test result, I'll investivate how to avoid this.

sainies commented 9 years ago

Fixed the SQL for the company events listing.

shunjikonishi commented 9 years ago

@sainies

Your implementation still doesn't pass all tests....