search

givery-technology / sample-test

13 stars 23 forks source link

Implemented #8

Closed NckHmml closed 9 years ago

NckHmml commented 9 years ago

https://github.com/NckHmml/sample-test-copy

I was not quite sure if it was allowed to use C# or not. And as an answer to that question would probably have a delay of day, I figured I might as well write it in C# and await the answer here.

Please note, when running the test with remote credentials to givery.nhum.nl, the initial response might be slow due and could exceed the 2s timeout. as the API needs a little time to start up (due to caching etc)

Please let me know if I were not supposed to make it in 'any language' so I can re-code it in a relevant language.

shunjikonishi commented 9 years ago

Thank you for taking our test.

Implementing by C# is allowed, but not so welcome. Because our company mostly use MacOS or Linux.

I don't have a Windows machine in office. So, I'll verify your app later.

I guess how to run your app is just execute NuGet.exe. Is it right? If it is wrong, please let me know how to run.

Also I saw your answer.md.
I guess you prefer Microsoft technology. If so, our company might not be comfortable for you...

Regards

Shunji Konishi

NckHmml commented 9 years ago

Hello Shunji Konishi,

I do understand the struggle of running .NET as I currently am on a Mac myself (running Windows on a VM) I currently configured a VPS to allow it being accessed remotely in a manner the tests would stil be able to run (see my config.json), it is hosted on givery.nhum.nl. Running it locally would require a rollback to the previous commit, but verifying the test remotely should work fine. Cloning my version of the tests locally and running them as you would normally should work, that is.

Sadly running a MVC application is not as straightforward as running NodeJS, it requires Visual Studio to run on a debug enviroment. (NuGet.exe is the package manager of Visual Studio actually)

The only reason I used C# is simply because I already have working experience with it, I actually would love to learn new things and methods of working :smile:

If you need any further information about anything, please feel free to ask such.

Sincerely, Nick Hummel

shunjikonishi commented 9 years ago

@NckHmml Sorry. I misunderstood how to run test with your app. Initially I didn't think givery.nhum.nl is host name. :)

With givery.nhum.nl, it passed all of tests. Great!

We'll contact you later. (Maybe from Max.)

Regards

Shunji

NckHmml commented 9 years ago

Hello Shunji Konishi,

nhum.nl is my domain name and I configured it to handle wildcard sub domains, so that is why. Though I will now disable the remote MySQL configuration so any tests that require fixtures probably will not succeed anymore, please contact me if you want me to re-enable it.

Also, thank you for your time and I will gladly await until further contact.

Sincerely, Nick Hummel

NckHmml commented 9 years ago

Hello Shunji Konishi,

As requested by Max I re-created the api in a language you guys are more familiar with (NodeJS). It can be found at https://github.com/NckHmml/sample-test-copy/tree/master/Givery/Givery. (Visual Studio caused this weird mapping, my apologies for that)

I created a copy as I used the fork to create a pull request, I accidentally lost my old Answer.md in the process.

The main script is 'Server.js' and 'Mocha spec/' should also run fine.

Sincerely, Nick Hummel

shunjikonishi commented 9 years ago

@NckHmml Thank you for re-creating test.

I verified your code with vagrant on Mac. It passed all tests. Very good.

Shunji Konishi