search

gizak / termui

Golang terminal dashboard
MIT License
13.11k stars 786 forks source link

Added units #163

Closed cnaize closed 5 years ago

cnaize commented 6 years ago

Hello!

Some time ago I tried to develop game with the library. Now I moving to another engine, but maybe my improvements will help to others.

Here is my basic implementation of Units. Unit is a layered Block with ability to store children with relative to the Unit coordinates. Main goal - you can add children to parent and then the children will moving with parent's movements.

Thanks

cnaize commented 5 years ago

Hello!

Any news? Will you merge this into master?

cjbassi commented 5 years ago

Hi, thanks for opening the pr! And apologies for the delay, just finished rewriting everything.

So this is definitely a cool feature and it looks well implemented, but I feel that it is somewhat niche, and also Grid has been reworked so it can store child widgets (although they have to be sized in a relative way) and you can have arbitrarily many Grids now. I'm going to close this, but I may come back to it if it ever comes up and I do appreciate appreciate you opening this PR!