Fix panic on table row count change

gizak / termui

Golang terminal dashboard

MIT License

13.23k stars 786 forks source link

Fix panic on table row count change #170

Closed verdverm closed 5 years ago

verdverm commented 6 years ago

This change will allow for dynamic row counts.

When the number of rows is greater than the original rows length, these statements don't get executed and the two ifs in the loop over the rows will index out-of-range.

dpetzold commented 6 years ago

Hi! Thank you for the commit but it didn't work quite right for me. I ended up with this:

https://github.com/dpetzold/termui/commit/253fa199cd1f517102700e682512d088a80ec1e2

cjbassi commented 5 years ago

Hi, thanks for this PR! So most of termui was reworked in 958a28575d7411492d25e42da3ad5a6e5947d9a4, and I think this issue has been taken care of since the Analysis function has been removed. If you run into issues still or notice something missing, feel free to create an issue.