search

gizak / termui

Golang terminal dashboard
MIT License
13.07k stars 783 forks source link

Recent changes broke Termeter, which uses this package #220

Closed jake-g closed 5 years ago

jake-g commented 5 years ago

I have never had a problem with termeter until recently. I suspect all the recent activity on this repo has something to do with it. Termeter relies on an older version of this project, termui.v1. Now it seems to have disappeared and termeter no longer builds. Is it possible to keep v1 so that legacy projects still work?

See:

The error i get:

>  ~ go get -u github.com/atsaki/termeter/cmd/termeter

package gopkg.in/gizak/termui.v1: unrecognized import path "gopkg.in/gizak/termui.v1"
cjbassi commented 5 years ago

Can you try it now? I readded the v1 tag and it works for me now.

jake-g commented 5 years ago

awesome, seems fine now

keithknott26 commented 5 years ago

I ended up writing an app just like termeter to use the new line graph features of termUI (the latest v3 code) but ended up with alot of flickering when the screen was rendered. I'll have to get a bug raised with you @cjbassi , is there a place I can send the code (which isn't ready to be made public just yet).

cjbassi commented 5 years ago

@keithknott26 Hmm, well I would recommend isolating the source of the flickering in your code, then creating a new issue and posting a minimal reproducible example that still causes the flickering.

Btw I was experiencing some flickering after the rewrite and it was because I had some erroneous calls to ui.Clear(), in case that helps.