search

gizak / termui

Golang terminal dashboard
MIT License
13.06k stars 783 forks source link

Suggestion: Consider changing default color from ColorWhite to ColorClear #249

Open DannyBen opened 4 years ago

DannyBen commented 4 years ago

Right now, when working with light terminal background, there are quite a few places that need to be overridden from ColorWhite to ColorClear (or some other color that is readable on white background).

Not only this makes development and experimentation a little lengthier, I suspect it also causes developers who publish packages that rely on termui to have a default theme that is not friendly to light background users.

I believe that if ColorClear is used as the default color, and both ColorBlack and ColorWhite are avoided in all the defaults, this will be a good starting point for everybody, and will provide a sensible theme that works out of the box for both dark and light background users.

drgrib commented 4 years ago

Agreed on this. I was going mad trying to get it to change from ColorWhite to the default terminal color and had no idea it was ColorClear until I saw this post. It shouldn't default to ColorWhite. This presupposes a very specific system setup and ignores the colors users have personally selected for readability in their own terminals.