search

gizatechxyz / giza-agents

Easy to use Verifiable AI and smart contracts interoperability.
https://docs.gizatech.xyz/products/ai-agents
MIT License
14 stars 10 forks source link

Improve Type Hints #36

Closed Gonmeso closed 5 months ago

Gonmeso commented 5 months ago

Type hinting is inconsistent throughout the code.

We should aim to improve this and make it more consistent and thus, useful in development.

To check which functions have missing hints or hints are not appropriate we can rely on the usage of mypy. We can run the following to have an overview:

mypy giza_actions --disallow-untyped-defs

This will show multiple hinting errors that we should aim to solve.

We can omit the errors coming from external packages that do not have type hints, for example:


giza_actions/utils.py:5: error: Skipping analyzing "giza": module is installed, but missing library stubs or py.typed marker  [import-untyped]```
Gerson2102 commented 5 months ago

Hello, can I work on this one? Is there any group to ask questions about this issue?

raphaelDkhn commented 5 months ago

Hey! Yes here is the Telegram link

Gerson2102 commented 5 months ago

Maybe in this project is not necessary to use Linux or something like that? Since i have been using WSL, and this project is made in python.

Gonmeso commented 5 months ago

Hi @Gerson2102

We mainly dev in MacOs (which is unix based) so Linux would be the preferred platform to develop, but if you want to use Windows it shouldn't be a problem either, but some unexpected bugs could appear

Gonmeso commented 5 months ago

Fixed in #44