search

gizatechxyz / orion

ONNX Runtime in Cairo 1.0 for verifiable ML inference using STARK
https://orion.gizatech.xyz
MIT License
161 stars 81 forks source link

bug: cannot compile due to `SpanSerde` #638

Open c0np4nn4 opened 4 weeks ago

c0np4nn4 commented 4 weeks ago

Bug Report

Orion version: 0.2.5

Current behavior: not compiled

Expected behavior: compiled

Steps to reproduce:

git clone git@github.com:gizatechxyz/orion.git
cd orion
scarb cairo-test -f multiple_linear_regression_test

Related code: The generic type T in the code below occurs the compile error

https://github.com/gizatechxyz/orion/blob/9c62277084487c05a7e99872cf70108c4cd41354/src/operators/tensor/core.cairo#L19-L31

insert short code snippets here

Other information: My scarb version

scarb 2.7.0 (e9a2b8716 2024-08-01)
cairo: 2.7.0 (https://crates.io/crates/cairo-lang-compiler/2.7.0)
sierra: 1.6.0
image
raphaelDkhn commented 4 weeks ago

Hello ! That's because Orion supports scarb 2.6.4, not 2.7.0.

We're working on a complete redesign of Orion, which will be much more efficient with a different approach instead of using ONNX. You can find this in the cleaning branch. But please have in mind that it's not ready yet, and there's still work to be done. I think I'll be releasing the new version in the next couple of weeks.

raphaelDkhn commented 4 weeks ago

I see that you're preparing a benchmark @c0np4nn4, happy to discuss further if you need to know more :) https://x.com/raphael_dkhn

ScottyDavies commented 2 weeks ago

@c0np4nn4 can I please be assigned this issue?