gizatt / pydrake_kuka

MIT License
5 stars 5 forks source link

ipykernel no longer supports python 2 #2

Closed peteflorence closed 5 years ago

peteflorence commented 5 years ago
Collecting ipykernel (from jupyter)
  Downloading https://files.pythonhosted.org/packages/11/0b/95330660f8cc5d63428b9886c800ea8d68842fd866389cf579acca4915be/ipykernel-5.1.0.tar.gz (101kB)
    Complete output from command python setup.py egg_info:
    ERROR: ipykernel requires Python version 3.4 or above.

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-fJaJGw/ipykernel/
You are using pip version 8.1.1, however version 18.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
The command '/bin/sh -c pip install --upgrade pip jupyter graphviz meshcat numpy trimesh pyglet' returned a non-zero code: 1
peteflorence commented 5 years ago

To clarify this breaks the docker build

peteflorence commented 5 years ago

I believe this is fixed by not --upgrade for jupyter. If everything works I can PR.

gizatt commented 5 years ago

That would be great! This hit another reponI have under CI and I've been putting off dealing with it... I'm happy to prioritize fixing it myself if its an issue.

peteflorence commented 5 years ago

Seems like everything works if just dont have --upgrade on jupyter

On Fri, Oct 19, 2018 at 4:37 PM Gregory Izatt notifications@github.com wrote:

That would be great! This hit another reponI have under CI and I've been putting off dealing with it... I'm happy to prioritize fixing it myself if its an issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gizatt/pydrake_kuka/issues/2#issuecomment-431491733, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYQqJo29B03O8Bx9hi_0VwGTus4WW1_ks5umjgHgaJpZM4XxXvs .

gizatt commented 5 years ago

I suspect the particular cause is that ipykernel v5.0.0 released around a month ago, and dropped Python 2.7 support. I'm waiting for CI to confirm this suspicion (just removing --upgrade doesn't fix CI, only people who have old ipykernel versions sitting around).

gizatt commented 5 years ago

Fixed by #3