search

gizmore / gwf3

Gizmore Website Framework
39 stars 23 forks source link

Lamb/Dog: Plugin git shows wrong error message #80

Open particleflux opened 4 years ago

particleflux commented 4 years ago

The git plugin shows a wrong amount of found results on the too_much error message. Is always says There are 1/10 matches. Try again.

This is probably due to the fact that a count() call is missing on the rply() call:

return $plugin->rply('too_much', array($__DOG_GIT_RESULTS, 10));

Should probably be:

return $plugin->rply('too_much', array(count($__DOG_GIT_RESULTS), 10));
dloser commented 4 years ago

Code in question: https://github.com/gizmore/gwf3/blob/cda62759d2add69ca89f9f6fc2570bed3a36cd6a/core/module/Dog/dog_plugins/dog_plugin/Source/git_Pb.php#L9 https://github.com/gizmore/gwf3/blob/cda62759d2add69ca89f9f6fc2570bed3a36cd6a/core/module/Dog/dog_plugins/dog_plugin/Source/git_Pb.php#L91

dloser commented 4 years ago

The message itself, even with correct values, doesn't make much sense.