gizmosachin / ColorSlider

🎨 Snapchat-style color picker in Swift
MIT License
288 stars 53 forks source link

prevent sending UIControl events twice #14

Closed wassup- closed 7 years ago

wassup- commented 7 years ago

This commit is to prevent sending UIControl events twice. This is a known issue, as can be seen here

wassup- commented 7 years ago

@gizmosachin Can you take a look at this PR?

gizmosachin commented 7 years ago

Hi @wassup-, sorry for the delay. I don't think this change is necessary. .touchUpInside and .touchUpOutside are different cases and changing it so that only .touchUpOutside is ever called breaks the contract of UIControlEvents.