Please update for Fastify >= 1.x

gj / fastify-ws

MIT License

55 stars 11 forks source link

Please update for Fastify >= 1.x #9

Closed sjorsjes closed 5 years ago

sjorsjes commented 5 years ago

I want to update to fastify 2.0 but this is the only plugin i use that is not ready for it. I tried to do a PR but I have no rights to do commits.

gj commented 5 years ago

@imrefazekas has helpfully opened a PR (#10) if you'd like to take a look @sjorsjes 🙂

I'll test the changes out after work today.

sjorsjes commented 5 years ago

That are the same changes as that I wanted to do a PR for. Works like a charm on Fastify 2.x, and should be backwords compatible with lower versions as well, because I don't think there were breaking changes in the fastify-plugin.

gj commented 5 years ago

Awesome — thanks for the info @sjorsjes !

gj commented 5 years ago

Published version 1.0.1 to NPM — maintains the same API as 1.0.0 and works with Fastify 1.7.0 - 2.x.

Beware that since 1.0.0 was published, the creator of the uws package has decided to abandon that project, so my advice going forward is to rely on the stable ws package (the default option for fastify-ws).