search

gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
229 stars 224 forks source link

Update the config #100

Closed vysogot closed 4 years ago

vysogot commented 4 years ago

Take latest versions and point to current phx executable and assets directory

iloveitaly commented 4 years ago

@gjaldon any thoughts here? Would be great to have these defaults in the master branch.

gjaldon commented 4 years ago

@vysogot thank you for the PR 💜

jesseshieh commented 4 years ago

@gjaldon @vysogot I think this may have broken some deploys. I am getting the following error now when I deploy. Do you mind if I revert this while we continue investigating? 

-----> Installing binaries
       Using cached node ...
       Installing Node ...
remote: mv: cannot stat ‘/tmp/node-v-linux-x64/*’: No such file or directory
jesseshieh commented 4 years ago

Looks like reverting fixed the error. I think issue was the node_version being blank, but I think it would be a problem to even bump the default node_version since a lot of apps probably rely on the defaults and might not be able to tolerate an automatic upgrade. @vysogot is there some way to modify the defaults for "new" apps without changing the settings for existing apps?