gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
229 stars 224 forks source link

Make scripts executable. #109

Open feluxe opened 4 years ago

feluxe commented 4 years ago

This PR makes the scripts in bin/ executable. I simply ran chmod 700 bin/*.

This is needed in order to make this buildpack work with the pack command line tool and heroku/cnb-shim.

cnb-shim cannot convert this buildpack into a cloud-native-buildpack if the executable bits are not set. Therefor the converted buildpack which you find at https://cnb-shim.herokuapp.com/v1/gjaldon/phoenix-static is broken and cannot be used with pack.

More info about the topic at hand.

It would help us a lot if this was merged. :-)

Cheers!

abtreece commented 1 year ago

bump.